simon/ezcurl
1
0
Fork 0
mirror of https://github.com/c-cube/ezcurl.git synced 2025-12-06 03:05:31 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review

Browse source 
Applied as suggested and we'll go from here.

Co-authored-by: Simon Cruanes <simon.cruanes.2007@m4x.org>
This commit is contained in:
Stéphane Lavergne 2025-02-07 22:14:06 -05:00 • committed by GitHub
parent dab9ca8190
commit 19db102b22
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/core/ezcurl_core.ml
View file

@ -148,28 +148,16 @@ let _apply_config (self : t) (config : Config.t) : unit =
let _eq_case a b = let _eq_case a b =
let low = String.lowercase_ascii in let low = String.lowercase_ascii in
String.compare (low a) (low b) = 0 String.equal (low a) (low b)
let _add_header_nodup (h : string * string) (headers : _ list ref) : unit = let _add_header_nodup (h : string * string) (headers : _ list ref) : unit =
let sq = List.to_seq !headers in let sq = List.to_seq !headers in
let k, v = h in let k, v = h in
match if not (List.exists (fun (tk,tv) -> _eq_case k tk && _eq_case v tv) !headers) then
Seq.find_index
(fun t ->
let tk, tv = t in
_eq_case k tk && _eq_case v tv)
sq
with
| None ->
headers := h :: !headers; headers := h :: !headers;
()
| Some _ -> () (* No duplicate *)
let _contains_resp_headers (h : string) (headers : string list) : bool = let _contains_resp_headers (h : string) (headers : string list) : bool =
let sq = List.to_seq headers in List.exists (_eq_case h) headers
match Seq.find_index (fun hh -> _eq_case h hh) sq with
| None -> false
| Some _ -> true
let _set_headers (self : t) (headers : _ list) : unit = let _set_headers (self : t) (headers : _ list) : unit =
let headers = List.map (fun (k, v) -> k ^ ": " ^ v) headers in let headers = List.map (fun (k, v) -> k ^ ": " ^ v) headers in
@ -398,11 +386,8 @@ let mk_res (self : t) headers body : (_ response, _) result =
let sse_frame_with_event sse_f v = let sse_frame_with_event sse_f v =
{ {
(!sse_f) with
event = Some v; event = Some v;
id = !sse_f.id;
data = !sse_f.data;
retry = !sse_f.retry;
empties = !sse_f.empties;
} }
let sse_frame_with_id sse_f v = let sse_frame_with_id sse_f v =