From 0226a4cef5fdd5b6b4c292fc85d721f2a1953a59 Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Tue, 4 Nov 2014 22:28:39 +0100 Subject: [PATCH] more warnings enabled; fix tests --- _tags | 1 + sequence.ml | 6 ------ tests/test_sequence.ml | 5 +++-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/_tags b/_tags index 5715982..35c72e6 100644 --- a/_tags +++ b/_tags @@ -28,3 +28,4 @@ : use_sequence # OASIS_STOP true: bin_annot +<**/*.ml>: warn_K, warn_Y, warn_X diff --git a/sequence.ml b/sequence.ml index 531a90d..ccb2b91 100644 --- a/sequence.ml +++ b/sequence.ml @@ -152,10 +152,6 @@ module MList = struct let of_seq seq = of_seq_with seq (fun _ -> ()) - let is_empty = function - | Nil -> true - | Cons _ -> false - let rec iter f l = match l with | Nil -> () | Cons (a, n, tl) -> @@ -618,8 +614,6 @@ module Set = struct let of_seq seq = fold (fun set x -> X.add x set) X.empty seq - let of_list l = of_seq (of_list l) - let to_list set = to_list (to_seq set) include X diff --git a/tests/test_sequence.ml b/tests/test_sequence.ml index 549fc85..6832b6c 100644 --- a/tests/test_sequence.ml +++ b/tests/test_sequence.ml @@ -56,7 +56,7 @@ let test_exists () = let test_length () = (1 -- 1000) |> S.length |> OUnit.assert_equal 1000 -let test_concat () = +let test_concat2 () = 1 -- 1000 |> S.map (fun i -> (i -- (i+1))) |> S.concat @@ -208,6 +208,7 @@ let suite = [ "test_empty" >:: test_empty; "test_repeat" >:: test_repeat; "test_concat" >:: test_concat; + "test_concat2" >:: test_concat2; "test_fold" >:: test_fold; "test_foldi" >:: test_foldi; "test_exists" >:: test_exists; @@ -231,5 +232,5 @@ let suite = "test_hashtbl" >:: test_hashtbl; "test_int_range" >:: test_int_range; "test_take" >:: test_take; - "test_regression1" >:: test_regression1 + "test_regression1" >:: test_regression1; ]