From 78eaa7a4ecbd78b3ee2db5884505de16f95e97a6 Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Thu, 15 Jan 2026 22:05:03 -0500 Subject: [PATCH] abstract type for Tracing_ stub --- src/private/tracing_.dummy.ml | 4 +++- src/private/tracing_.mli | 10 ++++++---- src/private/tracing_.real.ml | 6 ++++-- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/private/tracing_.dummy.ml b/src/private/tracing_.dummy.ml index ba6d0aff..4d02ac14 100644 --- a/src/private/tracing_.dummy.ml +++ b/src/private/tracing_.dummy.ml @@ -1,5 +1,7 @@ +type span = unit + let enabled () = false -let dummy_span = 0L +let dummy_span = () let enter_span _name = dummy_span let exit_span = ignore let set_thread_name = ignore diff --git a/src/private/tracing_.mli b/src/private/tracing_.mli index d4634697..e92e5629 100644 --- a/src/private/tracing_.mli +++ b/src/private/tracing_.mli @@ -1,6 +1,8 @@ -val dummy_span : int64 -val enter_span : string -> int64 -val exit_span : int64 -> unit -val with_span : string -> (int64 -> 'a) -> 'a +type span + +val dummy_span : span +val enter_span : string -> span +val exit_span : span -> unit +val with_span : string -> (span -> 'a) -> 'a val enabled : unit -> bool val set_thread_name : string -> unit diff --git a/src/private/tracing_.real.ml b/src/private/tracing_.real.ml index 4a928e27..1affc1eb 100644 --- a/src/private/tracing_.real.ml +++ b/src/private/tracing_.real.ml @@ -1,11 +1,13 @@ module Trace = Trace_core +type span = Trace.span + let enabled = Trace.enabled -let dummy_span = Int64.min_int +let dummy_span = Trace_core.Collector.dummy_span let dummy_file_ = "" let set_thread_name = Trace.set_thread_name -let[@inline] enter_span name : int64 = +let[@inline] enter_span name : span = if name = "" then dummy_span else