Avoid catch-all handlers

src/core/CCChar.ml

@@ -13,7 +13,7 @@ let pp_buf = Buffer.add_char
 let pp = Format.pp_print_char
 
 let of_int_exn = Char.chr
-let of_int c = try Some (of_int_exn c) with _ -> None
+let of_int c = try Some (of_int_exn c) with Invalid_argument _ -> None
 let to_int = Char.code
 
 (*$=

src/core/CCFloat.ml

@@ -114,7 +114,7 @@ let of_string_exn (a:string) = Stdlib.float_of_string a
 let of_string (a:string) = Stdlib.float_of_string a
 let of_string_opt (a:string) =
   try Some (Stdlib.float_of_string a)
-  with _ -> None
+  with Failure _ -> None
 
 
 let random n st = Random.State.float st n

src/core/CCIO.ml

@@ -222,11 +222,7 @@ let with_in_out ?(mode=0o644) ?(flags=[Open_creat]) filename f =
 let tee funs g () = match g() with
   | None -> None
   | Some x as res ->
-    List.iter
+    List.iter (fun f -> f x) funs;
-      (fun f ->
-         try f x
-         with _ -> ()
-      ) funs;
     res
 
 (* TODO: lines/unlines:  string gen -> string gen *)

src/core/CCInt.ml

@@ -202,7 +202,7 @@ let to_string = string_of_int
 
 let of_string s =
   try Some (int_of_string s)
-  with _ -> None
+  with Failure _ -> None
 
 (*$=
   None (of_string "moo")

src/core/CCString.ml

@@ -589,7 +589,7 @@ let split_on_char c s: _ list =
 let split ~by s = Split.list_cpy ~by s
 
 let compare_versions a b =
-  let of_int s = try Some (int_of_string s) with _ -> None in
+  let of_int s = try Some (int_of_string s) with Failure _ -> None in
   let rec cmp_rec a b = match a(), b() with
     | None, None -> 0
     | Some _, None -> 1