fix: oob(!!) in CCHash.bytes

tests for hashing strings
2025-12-06 03:05:28 -05:00 · 2025-05-06 10:01:31 -04:00 · 2025-05-06 10:01:31 -04:00
2 changed files with 3 additions and 1 deletions
--- a/src/core/CCHash.ml
+++ b/src/core/CCHash.ml
@ -101,7 +101,7 @@ let max_len_b_ = 128

 let bytes (x : bytes) =
  let h = ref fnv_offset_basis in
-  for i = 0 to min max_len_b_ (Bytes.length x) do
+  for i = 0 to min max_len_b_ (Bytes.length x-1) do
    (h := Int64.(mul !h fnv_prime));
    let byte = Char.code (Bytes.unsafe_get x i) in
    h := Int64.(logxor !h (of_int byte))
--- a/tests/core/t_hash.ml
+++ b/tests/core/t_hash.ml
@ -11,6 +11,8 @@ t @@ fun () -> char 'c' >= 0;;
 t @@ fun () -> int 152352 = int 152352;;
 t @@ fun () -> list_comm int [ 1; 2 ] = list_comm int [ 2; 1 ];;
 t @@ fun () -> list_comm int [ 1; 2 ] <> list_comm int [ 2; 3 ];;
+t @@ fun () -> string "abcd" >= 0;;
+t @@ fun () -> string "abc" <> string "abcd";;

 q Q.int (fun i ->
    Q.assume (i >= 0);
Author	SHA1	Message	Date
Simon Cruanes	ab7d0fcc09	fix: oob(!!) in CCHash.bytes Some checks are pending Build and Test / build (push) Waiting to run Details Build and Test / format (push) Waiting to run Details	2025-05-06 10:01:31 -04:00
Simon Cruanes	b55d3cfe6a	tests for hashing strings	2025-05-06 10:01:31 -04:00