fix CCString: clear buffer after use in sprintf

fix #487
regression test for #487
2026-03-07 21:27:55 -05:00 · 2026-03-02 17:36:31 -05:00 · 2026-03-02 17:36:02 -05:00
2 changed files with 8 additions and 2 deletions
--- a/src/core/CCFormat.ml
+++ b/src/core/CCFormat.ml
@ -398,7 +398,10 @@ let sprintf_ c format =
  Format.kfprintf
    (fun _fmt ->
      Format.pp_print_flush fmt ();
-      Buffer.contents buf)
+      let s = Buffer.contents buf in
+      Buffer.reset buf;
+      (* in case of reuse *)
+      s)
    fmt format

 let with_color_ksf ~f s fmt =
--- a/tests/core/t_string.ml
+++ b/tests/core/t_string.ml
@ -410,4 +410,7 @@ q
 ;;

 t @@ fun () -> "ab" < "abc";;
-t @@ fun () -> "123" < "14"
+t @@ fun () -> "123" < "14";;
+
+eq ~printer:Fun.id "a,b,c,d,e,f,g,"
+  (flat_map (CCFormat.sprintf "%c,") "abcdefg")
Author	SHA1	Message	Date
Simon Cruanes	aba4c79625	fix CCString: clear buffer after use in sprintf Some checks failed format / format (push) Has been cancelled Details Build and Test / build (push) Has been cancelled Details fix #487	2026-03-02 17:36:31 -05:00
Simon Cruanes	08e8fd3d54	regression test for #487	2026-03-02 17:36:02 -05:00