simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-09 04:17:56 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix otel.trace: record exception in with_span

Browse source 
close #71
This commit is contained in:
Simon Cruanes 2024-10-16 13:08:54 -04:00
parent f8079a13ea
commit 041d05eb9f
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/trace/opentelemetry_trace.ml
View file

@ -200,11 +200,19 @@ module Internal = struct
in in
Otel.Scope.with_ambient_scope sb.scope @@ fun () -> Otel.Scope.with_ambient_scope sb.scope @@ fun () ->
let rv = cb otrace_id in match cb otrace_id with
| res ->
let otel_span = exit_span' otrace_id sb in
Otel.Trace.emit [ otel_span ];
res
| exception e ->
let bt = Printexc.get_raw_backtrace () in
let otel_span = exit_span' otrace_id sb in Otel.Scope.record_exception sb.scope e bt;
Otel.Trace.emit [ otel_span ]; let otel_span = exit_span' otrace_id sb in
rv Otel.Trace.emit [ otel_span ];
Printexc.raise_with_backtrace e bt
let enter_span ~__FUNCTION__ ~__FILE__ ~__LINE__ ~data name : let enter_span ~__FUNCTION__ ~__FILE__ ~__LINE__ ~data name :
Trace_core.span = Trace_core.span =