From 068baca4c99c195dfb6f068a1a7eff9a31213ad3 Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Fri, 6 Mar 2026 11:37:35 -0500 Subject: [PATCH] follow otel semconv --- src/lib/globals.ml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/lib/globals.ml b/src/lib/globals.ml index a2d4478b..0c4bc3a3 100644 --- a/src/lib/globals.ml +++ b/src/lib/globals.ml @@ -20,13 +20,11 @@ let service_instance_id = ref None @since 0.12 *) let service_version = ref None -let sdk_name = "ocaml-otel" - (** @since NEXT_RELEASE *) let sdk_version : string = Version.(spf "%s at %s" version git_hash) let instrumentation_library = - make_instrumentation_scope ~version:sdk_version ~name:sdk_name () + make_instrumentation_scope ~version:sdk_version ~name:"opentelemetry" () (** Global attributes, initially set via OTEL_RESOURCE_ATTRIBUTES and modifiable by the user code. They will be attached to each outgoing metrics/traces. *) @@ -66,8 +64,8 @@ open struct let sdk_attributes = [ - (* "telemetry.sdk.language", `String "ocaml"; *) - "telemetry.sdk.name", `String sdk_name; + "telemetry.sdk.language", `String "ocaml"; + "telemetry.sdk.name", `String "opentelemetry"; "telemetry.sdk.version", `String sdk_version; ]