From 0c119c3effe67fef110b751bcd0230b16f5ccfc5 Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Sat, 17 Jan 2026 23:03:35 -0500 Subject: [PATCH] details --- src/trace/opentelemetry_trace.ml | 2 -- tests/bin/emit1.ml | 8 ++++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/trace/opentelemetry_trace.ml b/src/trace/opentelemetry_trace.ml index f2748e67..89e9ec59 100644 --- a/src/trace/opentelemetry_trace.ml +++ b/src/trace/opentelemetry_trace.ml @@ -35,8 +35,6 @@ open struct let k_span_ctx : OTEL.Span_ctx.t Ambient_context.Context.key = Ambient_context.Context.new_key () - (* TODO: params *) - let enter_span (self : state) ~__FUNCTION__ ~__FILE__ ~__LINE__ ~params:_ ~(data : (_ * Otrace.user_data) list) ~parent name : Otrace.span = let start_time = OTEL.Clock.now self.clock in diff --git a/tests/bin/emit1.ml b/tests/bin/emit1.ml index 2c7324ba..9e8a2235 100644 --- a/tests/bin/emit1.ml +++ b/tests/bin/emit1.ml @@ -68,7 +68,9 @@ let run_job () = let _arr : _ array = Sys.opaque_identity @@ Array.make (25 * 25551) 42.0 in - ignore _arr + ignore _arr; + + OT.Span.add_event scope (OT.Event.make "done with alloc") ); if !sleep_inner > 0. then ( @@ -76,10 +78,8 @@ let run_job () = Atomic.incr num_sleep ); - if j = 4 && !i mod 13 = 0 then failwith "oh no"; - (* simulate a failure *) - OT.Span.add_event scope (OT.Event.make "done with alloc") + if j = 4 && !i mod 13 = 0 then failwith "oh no" with Failure _ -> () done done;