simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-07 18:37:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix batch: default high watermark was wrong

Browse source
This commit is contained in:
Simon Cruanes 2025-12-09 20:50:44 -05:00
parent 173131ce84
commit 0eb27174f0
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/client/batch.ml
View file

@ -13,7 +13,7 @@ type 'a t = {
timeout: Mtime.span option; timeout: Mtime.span option;
} }
let default_high_watermark batch_size = min 10 (max (batch_size * 10) 1_000_000) let default_high_watermark batch_size = max 10 (min (batch_size * 10) 1_000_000)
let _dummy_start = Mtime.min_stamp let _dummy_start = Mtime.min_stamp
@ -83,8 +83,9 @@ let push (self : _ t) elems : [ `Dropped | `Ok ] =
let now = lazy (Mtime_clock.now ()) in let now = lazy (Mtime_clock.now ()) in
Util_atomic.update_cas self.st @@ fun state -> Util_atomic.update_cas self.st @@ fun state ->
if state.size >= self.high_watermark then if state.size >= self.high_watermark then
(* drop this to prevent queue from growing too fast *) ( (* drop this to prevent queue from growing too fast *)
`Dropped, state `Dropped,
state )
else ( else (
let start = let start =
if state.size = 0 && Option.is_some self.timeout then if state.size = 0 && Option.is_some self.timeout then