From 1cd536cb8e833849ac96081a6de76c876a6a2538 Mon Sep 17 00:00:00 2001
From: Matt Bray <mattjbray@gmail.com>
Date: Mon, 28 Mar 2022 15:03:12 +0100
Subject: [PATCH] refactor: get_global_attr_

---
 src/opentelemetry.ml | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/src/opentelemetry.ml b/src/opentelemetry.ml
index c0d7e1d8..acd49d9e 100644
--- a/src/opentelemetry.ml
+++ b/src/opentelemetry.ml
@@ -227,27 +227,23 @@ module Globals = struct
       |> List.map parse_pair
     with _ -> []
 
+  let get_global_attr_ key =
+    global_attributes
+    |> List.find_map (fun kv ->
+           if kv.key = key then
+             match kv.value with Some (String_value v) -> Some v | _ -> None
+           else None)
+
+
   (** Main service name metadata *)
   let service_name =
-    let n =
-      global_attributes
-      |> List.find_map (fun kv ->
-             if kv.key = Conventions.Attributes.Service.name then
-               match kv.value with Some (String_value v) -> Some v | _ -> None
-             else None)
-    in
+    let n = get_global_attr_ Conventions.Attributes.Service.name in
     let n = match n with Some v -> v | None -> "unknown_service" in
     ref n
 
   (** Namespace for the service *)
   let service_namespace =
-    let n =
-      global_attributes
-      |> List.find_map (fun kv ->
-             if kv.key = Conventions.Attributes.Service.namespace then
-               match kv.value with Some (String_value v) -> Some v | _ -> None
-             else None)
-    in
+    let n = get_global_attr_ Conventions.Attributes.Service.namespace in
     ref n
 
   let instrumentation_library =