simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-09 12:23:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #16 from AestheticIntegration/set-global-attrs

Browse source 
feat: use a ref for Globals.global_attributes
This commit is contained in:
Simon Cruanes 2022-04-19 13:28:33 -04:00 • committed by GitHub
commit 51cebfd383
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/opentelemetry.ml
View file

@ -292,12 +292,15 @@ module Globals = struct
~version:"%%VERSION%%"
~name:"ocaml-opentelemetry" ()
(** Global attributes, set via OTEL_RESOURCE_ATTRIBUTES *)
let global_attributes : key_value list =
(** Global attributes, initially set
via OTEL_RESOURCE_ATTRIBUTES and modifiable
by the user code. They will be attached to each outgoing metrics/traces. *)
let global_attributes : key_value list ref =
let parse_pair s = match String.split_on_char '=' s with
| [a;b] -> default_key_value ~key:a ~value:(Some (String_value b)) ()
| _ -> failwith (Printf.sprintf "invalid attribute: %S" s)
in
ref @@
try
Sys.getenv "OTEL_RESOURCE_ATTRIBUTES" |> String.split_on_char ','
|> List.map parse_pair
@ -306,7 +309,7 @@ module Globals = struct
(* add global attributes to this list *)
let merge_global_attributes_ into : _ list =
let not_redundant kv = List.for_all (fun kv' -> kv.key <> kv'.key) into in
List.rev_append (List.filter not_redundant global_attributes) into
List.rev_append (List.filter not_redundant !global_attributes) into
let mk_attributes ?(service_name = !service_name) ?(attrs=[]) () : _ list =
let l = List.map _conv_key_value attrs in