simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-10 12:45:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Check for on_click registration exactly once

Browse source
This commit is contained in:
Shon Feder 2025-09-02 15:00:11 -04:00
parent 93803581b7
commit 54b62af1a2
No known key found for this signature in database
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/core/opentelemetry.ml
View file

@ -1455,6 +1455,11 @@ end
alarms/intervals to emit them. *) alarms/intervals to emit them. *)
module Metrics_callbacks = struct module Metrics_callbacks = struct
open struct open struct
(* [true] iff the initial list of metric callbacks has already been registered
with `on_tick`. This registration must only happen once, after which,
[registered_with_on_tick] will forever be [false]. *)
let registered_with_on_tick : bool Atomic.t = Atomic.make false
let cbs_ : (unit -> Metrics.t list) AList.t = AList.make () let cbs_ : (unit -> Metrics.t list) AList.t = AList.make ()
end end
@ -1464,7 +1469,9 @@ module Metrics_callbacks = struct
of metrics. It might be called regularly by the backend, in particular of metrics. It might be called regularly by the backend, in particular
(but not only) when {!Collector.tick} is called. *) (but not only) when {!Collector.tick} is called. *)
let register f : unit = let register f : unit =
if AList.is_empty cbs_ then (* sets [registered_with_on_tick] to [true] atomically, iff it is currently
[false]. *)
if Atomic.compare_and_set registered_with_on_tick false true then
(* make sure we call [f] (and others) at each tick *) (* make sure we call [f] (and others) at each tick *)
Collector.on_tick (fun () -> Collector.on_tick (fun () ->
let m = List.map (fun f -> f ()) (AList.get cbs_) |> List.flatten in let m = List.map (fun f -> f ()) (AList.get cbs_) |> List.flatten in