From 858de42a2bd6d3ef527a9716f193edab47292bdf Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Thu, 12 Mar 2026 20:49:35 -0400 Subject: [PATCH] revert to just dune-build-info --- .gitignore | 3 --- dune-project | 3 ++- opentelemetry.opam | 1 + src/lib/dune | 24 +----------------------- src/lib/gen_git_index_path.sh | 2 -- src/lib/gen_version.sh | 6 ------ src/lib/globals.ml | 2 +- src/lib/version.ml | 4 ++++ src/lib/version.mli | 7 +------ 9 files changed, 10 insertions(+), 42 deletions(-) delete mode 100644 src/lib/gen_git_index_path.sh delete mode 100644 src/lib/gen_version.sh create mode 100644 src/lib/version.ml diff --git a/.gitignore b/.gitignore index e109d796..85d4d798 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,3 @@ _opam *.install *.exe *.tmp -src/lib/version.ml -src/lib/.git_index_path -src/lib/.git_index.lnk diff --git a/dune-project b/dune-project index e0f924ee..4f3cbf9d 100644 --- a/dune-project +++ b/dune-project @@ -49,7 +49,8 @@ (>= 0.27) (< 0.28))) (mtime - (>= "1.4"))) + (>= "1.4")) + dune-build-info) (depopts atomic trace thread-local-storage lwt eio picos) (conflicts (trace diff --git a/opentelemetry.opam b/opentelemetry.opam index 962fd3e5..cbe391fd 100644 --- a/opentelemetry.opam +++ b/opentelemetry.opam @@ -26,6 +26,7 @@ depends: [ "ocaml-lsp-server" {with-dev-setup} "ocamlformat" {with-dev-setup & >= "0.27" & < "0.28"} "mtime" {>= "1.4"} + "dune-build-info" ] depopts: ["atomic" "trace" "thread-local-storage" "lwt" "eio" "picos"] conflicts: [ diff --git a/src/lib/dune b/src/lib/dune index 1e6aff4a..5ac62e76 100644 --- a/src/lib/dune +++ b/src/lib/dune @@ -1,26 +1,3 @@ -(rule - (target .git_index_path) - (deps (universe) gen_git_index_path.sh) - (action - (with-stdout-to - .git_index_path - (run sh gen_git_index_path.sh)))) - -(rule - (target .git_index.lnk) - (action - (run ln -sf %{read-lines:.git_index_path} %{target}))) - -(rule - (target version.ml) - (deps - (file .git_index.lnk) - gen_version.sh) - (action - (with-stdout-to - version.ml - (run sh gen_version.sh)))) - (library (name opentelemetry) (public_name opentelemetry) @@ -44,6 +21,7 @@ (re_export opentelemetry.ambient-context) (re_export opentelemetry.atomic) (re_export hmap) + dune-build-info mtime mtime.clock.os pbrt diff --git a/src/lib/gen_git_index_path.sh b/src/lib/gen_git_index_path.sh deleted file mode 100644 index 899fbc6c..00000000 --- a/src/lib/gen_git_index_path.sh +++ /dev/null @@ -1,2 +0,0 @@ -#!/bin/sh -git rev-parse --git-path index 2>/dev/null || echo /dev/null diff --git a/src/lib/gen_version.sh b/src/lib/gen_version.sh deleted file mode 100644 index aecb43eb..00000000 --- a/src/lib/gen_version.sh +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/sh -v=$(git describe --exact-match HEAD 2>/dev/null | sed 's/^v//') -[ -z "$v" ] && v=dev -h=$(git rev-parse HEAD 2>/dev/null) -[ -z "$h" ] && h=unknown -printf 'let version = "%s"\nlet git_hash = "%s"\n' "$v" "$h" diff --git a/src/lib/globals.ml b/src/lib/globals.ml index 0c4bc3a3..ab190703 100644 --- a/src/lib/globals.ml +++ b/src/lib/globals.ml @@ -21,7 +21,7 @@ let service_instance_id = ref None let service_version = ref None (** @since NEXT_RELEASE *) -let sdk_version : string = Version.(spf "%s at %s" version git_hash) +let sdk_version : string = Version.version let instrumentation_library = make_instrumentation_scope ~version:sdk_version ~name:"opentelemetry" () diff --git a/src/lib/version.ml b/src/lib/version.ml new file mode 100644 index 00000000..a037540d --- /dev/null +++ b/src/lib/version.ml @@ -0,0 +1,4 @@ +let version = + match Build_info.V1.version () with + | None -> "dev" + | Some v -> Build_info.V1.Version.to_string v diff --git a/src/lib/version.mli b/src/lib/version.mli index 050c8dad..64fe6591 100644 --- a/src/lib/version.mli +++ b/src/lib/version.mli @@ -1,7 +1,2 @@ val version : string -(** Version of the library, e.g. ["0.12"]. ["dev"] if not built from a release - tag. *) - -val git_hash : string -(** Full git commit hash at build time, e.g. ["b92159c1..."]. ["unknown"] if git - was unavailable. *) +(** Version of the library, e.g. ["0.12"]. ["dev"] if not built from a release. *)