From 979a3ab3c81c6320658d120c3865e7880844c2bd Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Sat, 27 Dec 2025 21:48:28 -0500 Subject: [PATCH] test: redact current ocaml version from signal-gatherer output this should make expect tests more robust. --- tests/client_e2e/signal_gatherer.ml | 9 ++++++++- tests/logs/test_logs_e2e.expected | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/client_e2e/signal_gatherer.ml b/tests/client_e2e/signal_gatherer.ml index b782aa48..061e7bcd 100644 --- a/tests/client_e2e/signal_gatherer.ml +++ b/tests/client_e2e/signal_gatherer.ml @@ -134,7 +134,14 @@ let run ?(port = default_port) () : _ Lwt.t = Lwt_stream.iter_s (fun s -> let open Lwt.Syntax in - let* () = Lwt_io.printl (Format.asprintf "%a" Signal.Pp.pp s) in + let printed = Format.asprintf "%a" Signal.Pp.pp s in + + (* redact current ocaml version, for expect tests *) + let printed = + CCString.replace ~which:`All ~sub:Sys.ocaml_version + ~by:"ocaml_version" printed + in + let* () = Lwt_io.printl printed in Lwt_io.flush Lwt_io.stdout) stream; ] diff --git a/tests/logs/test_logs_e2e.expected b/tests/logs/test_logs_e2e.expected index 2eae2a56..451aad62 100644 --- a/tests/logs/test_logs_e2e.expected +++ b/tests/logs/test_logs_e2e.expected @@ -19,7 +19,7 @@ [{ scope = Some( { name = "ocaml-otel"; - version = ""; + version = "%%VERSION_NUM%%"; attributes = []; dropped_attributes_count = 0 (* absent *); });