simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-08 03:47:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: use _conv_key_value

Browse source
This commit is contained in:
Matt Bray 2022-03-23 10:01:23 +00:00
parent 69889a7b9a
commit 9ba57c5df1
1 changed files with 13 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/opentelemetry.ml
View file

@ -183,15 +183,21 @@ end
type key_value = string * [`Int of int | `String of string | `Bool of bool | `None] type key_value = string * [`Int of int | `String of string | `Bool of bool | `None]
(**/**)
let _conv_value =
let open Proto.Common in
function
| `Int i -> Some (Int_value (Int64.of_int i))
| `String s -> Some (String_value s)
| `Bool b -> Some (Bool_value b)
| `None -> None
(**/**)
(**/**) (**/**)
let _conv_key_value (k,v) = let _conv_key_value (k,v) =
let open Proto.Common in let open Proto.Common in
let value = match v with let value = _conv_value v in
| `Int i -> Some (Int_value (Int64.of_int i))
| `String s -> Some (String_value s)
| `Bool b -> Some (Bool_value b)
| `None -> None
in
default_key_value ~key:k ~value () default_key_value ~key:k ~value ()
(**/**) (**/**)
@ -320,17 +326,7 @@ end = struct
let attributes = let attributes =
let open Proto.Common in let open Proto.Common in
let l = List.map let l = List.map _conv_key_value attrs in
(fun (k,v) ->
let value = match v with
| `Int i -> Some (Int_value (Int64.of_int i))
| `String s -> Some (String_value s)
| `Bool b -> Some (Bool_value b)
| `None -> None
in
default_key_value ~key:k ~value ())
attrs
in
let l = let l =
default_key_value ~key:"service.name" default_key_value ~key:"service.name"
~value:(Some (String_value service_name)) () :: l ~value:(Some (String_value service_name)) () :: l