From 9cb9c1081c8ae452dd5ed77fba406607d6289498 Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Fri, 10 Apr 2026 14:29:08 -0400 Subject: [PATCH] config: better defaults in Sdk, have batching enabled by default --- src/lib/sdk.ml | 5 +++-- tests/implicit_scope/sync/test_implicit_scope_sync.ml | 6 +++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/lib/sdk.ml b/src/lib/sdk.ml index d4e6bae2..485c48c4 100644 --- a/src/lib/sdk.ml +++ b/src/lib/sdk.ml @@ -54,8 +54,9 @@ let run_tick_callbacks : unit -> unit = Globals.run_tick_callbacks from their ticker. *) let tick : unit -> unit = Globals.run_tick_callbacks -let set ?(traces = Provider_config.default) ?(metrics = Provider_config.default) - ?(logs = Provider_config.default) (exp : Exporter.t) : unit = +let set ?(traces = Provider_config.make ~batch:400 ()) + ?(metrics = Provider_config.make ~batch:200 ()) + ?(logs = Provider_config.make ~batch:400 ()) (exp : Exporter.t) : unit = Self_debug.log Info (fun () -> "opentelemetry: SDK set up"); Atomic.set exporter (Some exp); let tracer : Tracer.t = diff --git a/tests/implicit_scope/sync/test_implicit_scope_sync.ml b/tests/implicit_scope/sync/test_implicit_scope_sync.ml index 234db6af..be526b39 100644 --- a/tests/implicit_scope/sync/test_implicit_scope_sync.ml +++ b/tests/implicit_scope/sync/test_implicit_scope_sync.ml @@ -19,7 +19,11 @@ let test_exporter : Otel.Exporter.t = let with_test_exporter f = (* uncomment for eprintf debugging: *) (* let test_exporter = Opentelemetry_client.Exporter_debug.debug test_exporter in*) - Otel.Sdk.set test_exporter; + Otel.Sdk.set + ~traces:(Otel.Provider_config.make ()) + ~metrics:(Otel.Provider_config.make ()) + ~logs:(Otel.Provider_config.make ()) + test_exporter; Fun.protect f ~finally:(fun () -> let sq = Opentelemetry_client_sync.Sync_queue.create () in Otel.Sdk.remove