simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-09 04:17:56 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

trace-collector: Use OTel semconv for __FUNCTION__ etc

Browse source
This commit is contained in:
Elliott Cable 2023-08-03 20:16:34 +00:00
parent 1a1c360f4c
commit 9e65566d88
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/trace/opentelemetry_trace.ml
View file

@ -13,7 +13,7 @@ let span_of_i64 (id : int64) : Otel.Span_id.t =
let collector () : Trace.collector = let collector () : Trace.collector =
let module M = struct let module M = struct
let with_span ~__FUNCTION__:_ ~__FILE__ ~__LINE__ ~data name cb = let with_span ~__FUNCTION__ ~__FILE__ ~__LINE__ ~data name cb =
let span_id = Otel.Span_id.create () in let span_id = Otel.Span_id.create () in
let span = conv_span_to_i64 span_id in let span = conv_span_to_i64 span_id in
@ -36,8 +36,20 @@ let collector () : Trace.collector =
let end_time = Otel.Timestamp_ns.now_unix_ns () in let end_time = Otel.Timestamp_ns.now_unix_ns () in
let o_span : Otel.Span.t = let o_span : Otel.Span.t =
let last_dot = String.rindex __FUNCTION__ '.' in
let module_path = String.sub __FUNCTION__ 0 last_dot in
let function_name =
String.sub __FUNCTION__ (last_dot + 1)
(String.length __FUNCTION__ - last_dot - 1)
in
let attrs = let attrs =
[ "file", `String __FILE__; "line", `Int __LINE__ ] @ data [
"code.filepath", `String __FILE__;
"code.lineno", `Int __LINE__;
"code.function", `String function_name;
"code.namespace", `String module_path;
]
@ data
in in
Otel.Span.create ~trace_id:new_scope.trace_id ~id:span_id ~start_time Otel.Span.create ~trace_id:new_scope.trace_id ~id:span_id ~start_time
~end_time ~attrs name ~end_time ~attrs name