simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-11 04:58:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix get_url test to take config.url into account

Browse source
This commit is contained in:
Corentin Leruth 2023-08-28 17:07:39 +02:00 • committed by Simon Cruanes
parent 329d45ee45
commit a62f1d891a
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/client-cohttp-lwt/opentelemetry_client_cohttp_lwt.ml
View file

@ -559,6 +559,9 @@ end
let setup_ ?(stop = Atomic.make false) ~(config : Config.t) () = let setup_ ?(stop = Atomic.make false) ~(config : Config.t) () =
debug_ := config.debug; debug_ := config.debug;
if config.url <> get_url () then set_url config.url;
let module B = let module B =
Backend Backend
(struct (struct

2
src/client-ocurl/opentelemetry_client_ocurl.ml
View file

@ -446,6 +446,8 @@ let setup_ ?(stop = Atomic.make false) ~(config : Config.t) () =
let ((module B) as backend) = mk_backend ~stop ~config () in let ((module B) as backend) = mk_backend ~stop ~config () in
Opentelemetry.Collector.set_backend backend; Opentelemetry.Collector.set_backend backend;
if config.url <> get_url () then set_url config.url;
if config.ticker_thread then ( if config.ticker_thread then (
let sleep_ms = min 5_000 (max 2 config.batch_timeout_ms) in let sleep_ms = min 5_000 (max 2 config.batch_timeout_ms) in
ignore (setup_ticker_thread ~stop ~sleep_ms backend () : Thread.t) ignore (setup_ticker_thread ~stop ~sleep_ms backend () : Thread.t)

4
tests/test_get_url.expected
View file

@ -1,2 +1,2 @@
ocurl url = http://localhost:4318 ocurl url = http://localhost:3000
cohttp url = http://localhost:4318 cohttp url = http://localhost:3000