use Clock.ptime_clock where it makes sense

This commit is contained in:
Simon Cruanes 2025-12-17 11:57:18 -05:00
parent 43cd3aa230
commit bef4bd88b2
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
11 changed files with 13 additions and 17 deletions

View file

@ -6,7 +6,6 @@
(>= %{ocaml_version} 5.0)) (>= %{ocaml_version} 5.0))
(libraries (libraries
(re_export opentelemetry) (re_export opentelemetry)
opentelemetry.ptime
(re_export opentelemetry-client) (re_export opentelemetry-client)
(re_export eio) (re_export eio)
(re_export eio.core) (re_export eio.core)

View file

@ -174,7 +174,7 @@ let create_exporter ?(config = Config.make ()) ~sw ~env () =
Bounded_queue_sync.create Bounded_queue_sync.create
~high_watermark:Bounded_queue.Defaults.high_watermark () ~high_watermark:Bounded_queue.Defaults.high_watermark ()
in in
Exporter_queued.create ~clock:Opentelemetry_ptime.clock ~q:bq ~consumer () Exporter_queued.create ~clock:Clock.ptime_clock ~q:bq ~consumer ()
|> Exporter_add_batching.add_batching ~config |> Exporter_add_batching.add_batching ~config
let create_backend = create_exporter let create_backend = create_exporter

View file

@ -7,7 +7,6 @@
(libraries (libraries
(re_export opentelemetry) (re_export opentelemetry)
(re_export opentelemetry-client) (re_export opentelemetry-client)
opentelemetry.ptime
opentelemetry-client.lwt opentelemetry-client.lwt
(re_export lwt) (re_export lwt)
(re_export cohttp-lwt) (re_export cohttp-lwt)

View file

@ -114,7 +114,7 @@ let create_exporter ?(config = Config.make ()) () =
Bounded_queue_sync.create Bounded_queue_sync.create
~high_watermark:Bounded_queue.Defaults.high_watermark () ~high_watermark:Bounded_queue.Defaults.high_watermark ()
in in
Exporter_queued.create ~clock:Opentelemetry_ptime.clock ~q:bq ~consumer () Exporter_queued.create ~clock:Clock.ptime_clock ~q:bq ~consumer ()
|> Exporter_add_batching.add_batching ~config |> Exporter_add_batching.add_batching ~config
let create_backend = create_exporter let create_backend = create_exporter

View file

@ -6,7 +6,6 @@
(pps lwt_ppx)) (pps lwt_ppx))
(libraries (libraries
(re_export opentelemetry) (re_export opentelemetry)
opentelemetry.ptime
opentelemetry.atomic opentelemetry.atomic
(re_export opentelemetry-client) (re_export opentelemetry-client)
(re_export opentelemetry-client.lwt) (re_export opentelemetry-client.lwt)

View file

@ -85,7 +85,7 @@ let create_exporter ?(config = Config.make ()) () =
Bounded_queue_sync.create Bounded_queue_sync.create
~high_watermark:Bounded_queue.Defaults.high_watermark () ~high_watermark:Bounded_queue.Defaults.high_watermark ()
in in
Exporter_queued.create ~clock:Opentelemetry_ptime.clock ~q:bq ~consumer () Exporter_queued.create ~clock:Clock.ptime_clock ~q:bq ~consumer ()
|> Exporter_add_batching.add_batching ~config |> Exporter_add_batching.add_batching ~config
let create_backend = create_exporter let create_backend = create_exporter

View file

@ -5,7 +5,6 @@
(re_export opentelemetry) (re_export opentelemetry)
opentelemetry.atomic opentelemetry.atomic
(re_export opentelemetry-client) (re_export opentelemetry-client)
(re_export opentelemetry.ptime)
(re_export curl) (re_export curl)
pbrt pbrt
threads threads

View file

@ -92,8 +92,7 @@ let create_exporter ?(config = Config.make ()) () : OTEL.Exporter.t =
~high_watermark:OTELC.Bounded_queue.Defaults.high_watermark () ~high_watermark:OTELC.Bounded_queue.Defaults.high_watermark ()
in in
OTELC.Exporter_queued.create ~clock:Opentelemetry_ptime.clock ~q:bq ~consumer OTELC.Exporter_queued.create ~clock:OTEL.Clock.ptime_clock ~q:bq ~consumer ()
()
|> OTELC.Exporter_add_batching.add_batching ~config:config.common |> OTELC.Exporter_add_batching.add_batching ~config:config.common
let create_backend = create_exporter let create_backend = create_exporter

View file

@ -35,7 +35,7 @@ let dummy () : t =
let active, trigger = Aswitch.create () in let active, trigger = Aswitch.create () in
{ {
active = (fun () -> active); active = (fun () -> active);
clock = Clock.unix; clock = Clock.ptime_clock;
emit_spans = Emitter.dummy; emit_spans = Emitter.dummy;
emit_metrics = Emitter.dummy; emit_metrics = Emitter.dummy;
emit_logs = Emitter.dummy; emit_logs = Emitter.dummy;

View file

@ -14,10 +14,10 @@
(preprocess (preprocess
(pps lwt_ppx)) (pps lwt_ppx))
(libraries (libraries
unix
threads threads
lwt lwt
lwt.unix lwt.unix
unix
opentelemetry opentelemetry
opentelemetry-client opentelemetry-client
opentelemetry-client-ocurl-lwt)) opentelemetry-client-ocurl-lwt))
@ -69,6 +69,7 @@
opentelemetry-cohttp-lwt opentelemetry-cohttp-lwt
opentelemetry-logs opentelemetry-logs
logs logs
unix
lwt.unix lwt.unix
logs.fmt)) logs.fmt))
@ -77,6 +78,7 @@
(modules cohttp_client) (modules cohttp_client)
(libraries (libraries
cohttp-lwt-unix cohttp-lwt-unix
unix
opentelemetry opentelemetry
opentelemetry-client-cohttp-lwt opentelemetry-client-cohttp-lwt
opentelemetry-cohttp-lwt)) opentelemetry-cohttp-lwt))

View file

@ -23,10 +23,9 @@ let num_tr = Atomic.make 0
let i = Atomic.make 0 let i = Atomic.make 0
let run_job clock _job_id iterations : unit = let run_job clock _job_id iterations : unit =
let tracer = OT.Tracer.get_main () in
let@ scope = let@ scope =
Atomic.incr num_tr; Atomic.incr num_tr;
OT.Tracer.with_ ~tracer ~kind:OT.Span.Span_kind_producer "loop.outer" OT.Tracer.with_ ~kind:OT.Span.Span_kind_producer "loop.outer"
~attrs:[ "i", `Int (Atomic.get i) ] ~attrs:[ "i", `Int (Atomic.get i) ]
in in
@ -38,7 +37,7 @@ let run_job clock _job_id iterations : unit =
(* parent scope is found via thread local storage *) (* parent scope is found via thread local storage *)
let@ scope = let@ scope =
Atomic.incr num_tr; Atomic.incr num_tr;
OT.Tracer.with_ ~tracer ~parent:scope ~kind:OT.Span.Span_kind_internal OT.Tracer.with_ ~parent:scope ~kind:OT.Span.Span_kind_internal
~attrs:[ "j", `Int j ] ~attrs:[ "j", `Int j ]
"loop.inner" "loop.inner"
in in
@ -55,8 +54,7 @@ let run_job clock _job_id iterations : unit =
try try
Atomic.incr num_tr; Atomic.incr num_tr;
let@ scope = let@ scope =
OT.Tracer.with_ ~tracer ~kind:OT.Span.Span_kind_internal ~parent:scope OT.Tracer.with_ ~kind:OT.Span.Span_kind_internal ~parent:scope "alloc"
"alloc"
in in
(* allocate some stuff *) (* allocate some stuff *)
if !stress_alloc_ then ( if !stress_alloc_ then (
@ -80,10 +78,11 @@ let run env proc iterations () : unit =
OT.Metrics_callbacks.( OT.Metrics_callbacks.(
with_set_added_to_main_exporter (fun set -> with_set_added_to_main_exporter (fun set ->
add_metrics_cb set (fun () -> add_metrics_cb set (fun () ->
let now = OT.Clock.now_main () in
OT.Metrics. OT.Metrics.
[ [
sum ~name:"num-sleep" ~is_monotonic:true sum ~name:"num-sleep" ~is_monotonic:true
[ int (Atomic.get num_sleep) ]; [ int ~now (Atomic.get num_sleep) ];
]))); ])));
let n_jobs = max 1 !n_jobs in let n_jobs = max 1 !n_jobs in