simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-08 03:47:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix possible data races in eio test bin

Browse source 
Since this test runs with multiple domains, we cannot mutate plain refs
as we were without inviting data races.
This commit is contained in:
Shon Feder 2025-09-07 10:44:04 -04:00
parent ecd6ed0b73
commit c30f3b1c0c
No known key found for this signature in database
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/bin/emit1_eio.ml
View file

@ -11,22 +11,22 @@ let sleep_outer = ref 2.0
let n_jobs = ref 1 let n_jobs = ref 1
let num_sleep = Atomic.make 0
let stress_alloc_ = ref true let stress_alloc_ = ref true
let num_sleep = Atomic.make 0
let stop = Atomic.make false let stop = Atomic.make false
let num_tr = Atomic.make 0 let num_tr = Atomic.make 0
(* Counter used to mark simulated failures *) (* Counter used to mark simulated failures *)
let i = ref 0 let i = Atomic.make 0
let run_job clock _job_id iterations : unit = let run_job clock _job_id iterations : unit =
let@ scope = let@ scope =
Atomic.incr num_tr; Atomic.incr num_tr;
OT.Trace.with_ ~kind:OT.Span.Span_kind_producer "loop.outer" OT.Trace.with_ ~kind:OT.Span.Span_kind_producer "loop.outer"
~attrs:[ "i", `Int !i ] ~attrs:[ "i", `Int (Atomic.get i) ]
in in
for j = 0 to iterations do for j = 0 to iterations do
@ -52,7 +52,7 @@ let run_job clock _job_id iterations : unit =
~severity:Severity_number_info "inner at %d" j; ~severity:Severity_number_info "inner at %d" j;
]); ]);
incr i; Atomic.incr i;
try try
Atomic.incr num_tr; Atomic.incr num_tr;
@ -68,7 +68,7 @@ let run_job clock _job_id iterations : unit =
let () = Eio.Time.sleep clock !sleep_inner in let () = Eio.Time.sleep clock !sleep_inner in
Atomic.incr num_sleep; Atomic.incr num_sleep;
if j = 4 && !i mod 13 = 0 then failwith "oh no"; if j = 4 && Atomic.get i mod 13 = 0 then failwith "oh no";
(* simulate a failure *) (* simulate a failure *)
Opentelemetry.Scope.add_event scope (fun () -> Opentelemetry.Scope.add_event scope (fun () ->