simon/ocaml-opentelemetry
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-08 03:47:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

the test library was wrong!!!

Browse source 
turns out, find_map is the wrong operation when resources object
actually contain more than one item.
This commit is contained in:
Simon Cruanes 2025-12-20 23:35:55 -05:00
parent 95e8c78ff8
commit f8269ed1c8
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/client_e2e/clients_e2e_lib.ml
View file

@ -32,11 +32,12 @@ let signals_from_batch (signal_batch : Client.Resource_signal.t) =
let filter_map_spans f signals = let filter_map_spans f signals =
signals signals
|> List.filter_map (function |> List.concat_map (function
| `Log _ | `Metric _ -> None | `Log _ | `Metric _ -> []
| `Trace (r : Proto.Trace.resource_spans) -> | `Trace (r : Proto.Trace.resource_spans) ->
r.scope_spans r.scope_spans
|> List.find_map (fun ss -> ss.Proto.Trace.spans |> List.find_map f)) |> List.concat_map (fun ss ->
ss.Proto.Trace.spans |> List.filter_map f))
let count_spans_with_name name signals = let count_spans_with_name name signals =
signals signals
@ -49,12 +50,12 @@ let count_spans_with_name name signals =
let filter_map_metrics f signals = let filter_map_metrics f signals =
signals signals
|> List.filter_map (function |> List.concat_map (function
| `Log _ | `Trace _ -> None | `Log _ | `Trace _ -> []
| `Metric (r : Proto.Metrics.resource_metrics) -> | `Metric (r : Proto.Metrics.resource_metrics) ->
r.scope_metrics r.scope_metrics
|> List.find_map (fun ss -> |> List.concat_map (fun ss ->
ss.Proto.Metrics.metrics |> List.find_map f)) ss.Proto.Metrics.metrics |> List.filter_map f))
let count_metrics_with_name name signals = let count_metrics_with_name name signals =
signals signals
@ -90,12 +91,12 @@ let get_metric_values name signals =
let filter_map_logs (f : Proto.Logs.log_record -> 'a option) signals : 'a list = let filter_map_logs (f : Proto.Logs.log_record -> 'a option) signals : 'a list =
signals signals
|> List.filter_map (function |> List.concat_map (function
| `Metric _ | `Trace _ -> None | `Metric _ | `Trace _ -> []
| `Log (r : Proto.Logs.resource_logs) -> | `Log (r : Proto.Logs.resource_logs) ->
r.scope_logs r.scope_logs
|> List.find_map (fun ss -> |> List.concat_map (fun ss ->
ss.Proto.Logs.log_records |> List.find_map f)) ss.Proto.Logs.log_records |> List.filter_map f))
let count_logs_with_body p signals = let count_logs_with_body p signals =
signals signals