Simon Cruanes
b778ffdac3
reduce allocations in push
2025-09-08 08:09:05 -04:00
Simon Cruanes
026465f770
reduce size of critical section
...
better to reverse the list without holding the lock,
as it allocates and might have to yield to another thread
or domain, pause, etc.
2025-09-08 08:08:29 -04:00
Simon Cruanes
76efa381c3
comments
2025-09-08 08:08:18 -04:00
Shon Feder
8a8299020a
Make Batch actually be thread safe
2025-09-07 23:26:20 -04:00
Shon Feder
474d43bdad
Use domain ID instead of thread ID in Eio collector
...
Eio programs are not generally expected to use threads for concurrency,
but they may well use different domains which we'd want to track during
debugging.
2025-09-07 23:25:25 -04:00
Shon Feder
c30f3b1c0c
Fix possible data races in eio test bin
...
Since this test runs with multiple domains, we cannot mutate plain refs
as we were without inviting data races.
2025-09-07 23:24:00 -04:00
Simon Cruanes
ecd6ed0b73
Merge pull request #100 from shonfeder/fix-non-atomic-metric-callbacks
...
fix: make metric callbacks atomic
2025-09-02 15:15:16 -04:00
Simon Cruanes
fa610ed535
Update src/core/opentelemetry.ml
2025-09-02 15:08:22 -04:00
Shon Feder
54b62af1a2
Check for on_click registration exactly once
2025-09-02 15:00:11 -04:00
Shon Feder
93803581b7
fix: make metric callbacks atomic
...
The use of a non-threadsafe mutable reference for the metrics callbacks
was resulting in a race condition that would sometimes produce
non-deterministic results in the integration tests.
This has not affected the lwt-based collector, because of the single
threaded concurrency Lwt enforces, but it began to show up in the WIP
Eio rewrite, for which I am testing on cross-domain programs.
I suspect this may have also bee affecting the ocurl collector, but we
don't have integration test running on that yet.
2025-09-02 14:41:26 -04:00
Simon Cruanes
d9dd7ce32c
Merge pull request #103 from shonfeder/eio-fixes
...
Fix Eio collector to work accross domains
2025-09-02 09:26:18 -04:00
Simon Cruanes
5facbdfc6d
Merge pull request #101 from ajbt200128/austin/logs-integration
...
feature: Logs integration
2025-08-25 10:10:25 -04:00
Shon Feder
16de06aac5
Make emit1_eio.ml emit deterministic signals
...
As soon as we start running this in multible system threads, the race to
trigger the globals `stop` and `iterations` makes the signal emissions
non-deterministic, which makes the test kind of meaningless. This change
should make them determinstic.
2025-08-01 14:10:02 -04:00
Shon Feder
0890a1a5cd
Use multiple system threads in integration tests
2025-08-01 13:56:50 -04:00
Shon Feder
ddbdc80d57
make Eio collector thread safe
...
The backend cannot take a switch, because switches cannot be shared
across domains, but the backend is accessed across domains from a global
variable.
2025-08-01 13:56:50 -04:00
Shon Feder
7cdadfaeeb
Fix exception message
2025-08-01 13:56:50 -04:00
ajbt200128
7c35c764bb
add install workflow test
2025-07-31 14:36:17 -07:00
ajbt200128
e7367f9d27
remove automatic license notice
2025-07-31 14:31:27 -07:00
ajbt200128
1e6ee91da4
add tests
2025-07-31 14:27:57 -07:00
ajbt200128
fbb280974a
feat: add Logs integration
...
This PR upstreams the logs integration I wrote for Semgrep, and that
we've been using succesfully for months!
2025-07-31 14:25:52 -07:00
ajbt200128
46d1289d95
fix: opentelemetry exception attr spec
...
this brings the exception attributes in line with the spec
https://opentelemetry.io/docs/specs/semconv/exceptions/exceptions-spans/ .
It seems we were missing the preceding `exception.`.
2025-07-23 09:01:52 -05:00
Simon Cruanes
07513133ae
Merge pull request #98 from shonfeder/add-eio-backend
...
Add Eio collector
2025-07-14 15:58:11 -04:00
Shon Feder
621045435c
Fix eio_main dep
2025-07-14 15:09:04 -04:00
Shon Feder
e678a93570
Fix spelling of variable
2025-07-14 12:34:39 -04:00
Shon Feder
69d15df4f1
Fix deps
2025-07-14 12:34:39 -04:00
Shon Feder
26baa4d26b
Remove testing branch from PR
2025-07-12 12:34:23 -04:00
Shon Feder
94772c7fe4
Fix GitHub actions for Ocaml5 specific tests
...
Co-authored-by: Puneeth Chaganti <punchagan@muse-amuse.in>
2025-07-12 00:30:31 -04:00
Shon Feder
ea66f65187
Add tls-eio dep
2025-07-12 00:30:31 -04:00
Shon Feder
a0bee6bfcc
Only install Eio in builds for ocaml >= 5
2025-07-12 00:30:31 -04:00
Shon Feder
7746c871c2
Add Eio collector
2025-07-12 00:30:31 -04:00
Simon Cruanes
a5af3c9b65
Merge pull request #96 from shonfeder/tests
...
Add integration tests for collectors
2025-07-12 00:19:33 -04:00
Shon Feder
a71fc32091
Fix docs
2025-07-11 17:57:49 -04:00
Simon Cruanes
7cd3d0321b
detail
2025-07-11 15:41:07 -04:00
Shon Feder
f1b7a2237c
Specify and document the Signal_gatherer API
2025-07-11 13:48:40 -04:00
Shon Feder
8288bcb59b
Use containers in tests
...
To get access to useful functions that are not in the Stdlib in OCaml 4.08.
2025-07-10 16:11:20 -04:00
Shon Feder
16daccb6df
Remove cruft from old testing method
...
Also document the signal reporter executable
2025-07-10 15:58:53 -04:00
Shon Feder
5bf8eea5f1
Define find_map for 4.08 compat
2025-07-10 09:29:20 -04:00
Shon Feder
ef5d7af3e7
Remove unneeded dependency
2025-07-08 21:33:08 -04:00
Shon Feder
87cfd5e31e
Add test harness for instrumented applications
2025-07-08 21:30:03 -04:00
Shon Feder
a44e0cd3b5
Add common type for signals
2025-07-08 21:28:55 -04:00
Shon Feder
b6448b330d
Used default_url
2025-07-08 21:28:55 -04:00
Shon Feder
a95b787a7b
Allowing breaking with ctrl-c
2025-07-08 21:28:55 -04:00
Shon Feder
00840e0b88
Add pretty printer utils
...
These combinators seem tiny, but they simpflify code where they are used
quite a lot.
2025-07-08 21:28:55 -04:00
Shon Feder
33104f231e
Add Signal.Decode module
...
For testing
2025-07-08 21:28:55 -04:00
Shon Feder
916b962c43
Expose default_url in config
...
No reason to keep this value hidden, and we want to reuse it for tests.
2025-07-08 21:28:55 -04:00
Shon Feder
39920ed109
Fix Signal encoder name choice
...
Don't know why I didn't opt for this clearer name originally.
2025-07-08 21:28:55 -04:00
Shon Feder
d3235a1864
Remove unneeded encoder reset
...
We reset the encoder if we are reusing one, and we generate a fresh new
one otherwise.
2025-07-08 21:28:55 -04:00
Simon Cruanes
841d223ed2
Merge pull request #97 from shonfeder/factor-out-lwt-batching
...
Factor batching logic out of the cohttp-lwt client
2025-07-01 14:33:37 -04:00
Shon Feder
8b48843459
Correct size and optimize representation
...
Since we need to traverse the elements added to count up the new size,
we can use that pass to add the elements onto our FIFO queue, and then
drain the queue in one last pass to reverse. IIUC, this should give us
liner complexity of the batch retrieval.
2025-06-30 22:52:49 -04:00
Shon Feder
31a712dd30
Allowing configuring start time
2025-06-30 22:28:30 -04:00
