ocaml-opentelemetry/tests/implicit_scope/sync/dune at a43587f2a67a78e5a8115d1f4c490b5448d1a7ec - simon/ocaml-opentelemetry - Forgejo: Beyond coding. We Forge.

simon/ocaml-opentelemetry

mirror of https://github.com/ocaml-tracing/ocaml-opentelemetry.git synced 2026-03-08 03:47:59 -04:00

Simon Cruanes 1ebd474423 fix: critical bugs found in code review

Bug #1: Fix worker count logic in generic_consumer
- Was: min 2 (max 500 n_workers) - always created 2 workers
- Now: max 2 (min 500 n_workers) - properly clamps between 2-500
- Impact: Worker configuration was completely ignored

Bug #2: Handle missing dot in __FUNCTION__ name
- Added exception handling for String.rindex in trace span creation
- Prevents crash when tracing top-level or non-module functions
- Uses option type for module_path when no dot is present
- Scoped try/catch to only parsing logic

2026-02-08 06:16:05 +00:00

9 lines

176 B

Text

Raw Blame History

 (tests
  (names test_implicit_scope_sync)
  (package opentelemetry-client-cohttp-lwt)
  (libraries
   threads
   alcotest
   opentelemetry
   unix
   opentelemetry-client-cohttp-lwt))