From 1b5e827d6544f77e3775be6625bd20b504283e2f Mon Sep 17 00:00:00 2001 From: Simon Cruanes Date: Thu, 3 Aug 2023 15:37:02 -0400 Subject: [PATCH] fix inconsistency --- src/core/collector.ml | 2 +- src/core/trace_core.ml | 2 +- src/tef/trace_tef.ml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/collector.ml b/src/core/collector.ml index a0b772d..407ce27 100644 --- a/src/core/collector.ml +++ b/src/core/collector.ml @@ -33,7 +33,7 @@ module type S = sig val enter_manual_span : parent:explicit_span option -> - ?__FUNCTION__:string -> + __FUNCTION__:string option -> __FILE__:string -> __LINE__:int -> data:(string * user_data) list -> diff --git a/src/core/trace_core.ml b/src/core/trace_core.ml index 1984dfe..e8b255a 100644 --- a/src/core/trace_core.ml +++ b/src/core/trace_core.ml @@ -31,7 +31,7 @@ let enter_explicit_span_collector_ (module C : Collector.S) ~parent ?__FUNCTION__ ~__FILE__ ~__LINE__ ?(data = fun () -> []) name : explicit_span = let data = data () in - C.enter_manual_span ~parent ?__FUNCTION__ ~__FILE__ ~__LINE__ ~data name + C.enter_manual_span ~parent ~__FUNCTION__ ~__FILE__ ~__LINE__ ~data name let[@inline] enter_manual_sub_span ~parent ?__FUNCTION__ ~__FILE__ ~__LINE__ ?data name : explicit_span = diff --git a/src/tef/trace_tef.ml b/src/tef/trace_tef.ml index 756d577..bad9a65 100644 --- a/src/tef/trace_tef.ml +++ b/src/tef/trace_tef.ml @@ -342,7 +342,7 @@ let collector ~out () : collector = Fun.protect ~finally (fun () -> f span) - let enter_manual_span ~(parent : explicit_span option) ?__FUNCTION__:_ + let enter_manual_span ~(parent : explicit_span option) ~__FUNCTION__:_ ~__FILE__:_ ~__LINE__:_ ~data name : explicit_span = (* get the id, or make a new one *) let id =