simon/ocaml-trace
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-trace.git synced 2026-03-07 18:37:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: remove current_span from collector

Browse source 
probably orthogonal, collectors can provide this optionally via
ambient-context if desired. doesn't need to be in the Trace_core
collector itself.
This commit is contained in:
Simon Cruanes 2026-01-15 17:19:49 -05:00
parent 0bd8868172
commit 66816040aa
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/collector.ml
View file

@ -28,10 +28,6 @@ module Callbacks = struct
exit_span: 'st -> span -> unit;
(** Exit a span. Must be called exactly once per span. Additional
constraints on nesting, threads, etc. vary per collector. *)
current_span: 'st -> span option;
(** Access the current span, if supported. Returns [None] if there is no
current span or if the current span isn't tracked by the collector.
*)
add_data_to_span: 'st -> span -> (string * user_data) list -> unit;
message:
'st ->
@ -66,14 +62,12 @@ module Callbacks = struct
(** Callbacks taking a state ['st] *)
(** Helper to create backends in a future-proof way *)
let make ~enter_span ~exit_span ?(current_span = fun _ -> None)
~add_data_to_span ~message ~counter_int ~counter_float
?(extension = fun _ _ -> ()) ?(init = ignore) ?(shutdown = ignore) () :
_ t =
let make ~enter_span ~exit_span ~add_data_to_span ~message ~counter_int
~counter_float ?(extension = fun _ _ -> ()) ?(init = ignore)
?(shutdown = ignore) () : _ t =
{
enter_span;
exit_span;
current_span;
add_data_to_span;
message;
counter_int;