simon/ocaml-trace
1
0
Fork 0
mirror of https://github.com/ocaml-tracing/ocaml-trace.git synced 2026-03-08 20:07:55 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat trace-tef: print names of non-closed spans upon exit

Browse source
This commit is contained in:
Simon Cruanes 2025-03-13 20:39:31 -04:00
parent c5e813170d
commit 86d4fc25ac
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/tef/trace_tef.ml
View file

@ -220,6 +220,17 @@ let block_signals () =
: _ list) : _ list)
with _ -> () with _ -> ()
let print_non_closed_spans_warning spans =
let module Str_set = Set.Make (String) in
Printf.eprintf "trace-tef: warning: %d spans were not closed\n"
(Span_tbl.length spans);
let names = ref Str_set.empty in
Span_tbl.iter (fun _ span -> names := Str_set.add span.name !names) spans;
Str_set.iter
(fun name -> Printf.eprintf " span %S was not closed\n" name)
!names;
flush stderr
(** Background thread, takes events from the queue, puts them (** Background thread, takes events from the queue, puts them
in context using local state, and writes fully resolved in context using local state, and writes fully resolved
TEF events to [out]. *) TEF events to [out]. *)
@ -288,9 +299,7 @@ let bg_thread ~mode ~out (events : Event.t B_queue.t) : unit =
~args:[] writer; ~args:[] writer;
(* warn if app didn't close all spans *) (* warn if app didn't close all spans *)
if Span_tbl.length spans > 0 then if Span_tbl.length spans > 0 then print_non_closed_spans_warning spans;
Printf.eprintf "trace-tef: warning: %d spans were not closed\n%!"
(Span_tbl.length spans);
() ()
(** Thread that simply regularly "ticks", sending events to (** Thread that simply regularly "ticks", sending events to