diff --git a/src/core/collector.ml b/src/core/collector.ml index 2ccdd37..93f8faa 100644 --- a/src/core/collector.ml +++ b/src/core/collector.ml @@ -53,7 +53,7 @@ module type S = sig (** Exit an explicit span. @since 0.3 *) - val add_data : (string * user_data) list -> unit + val add_data_to_current_span : (string * user_data) list -> unit (** @since Adds data to the current, implicit span. NEXT_RELEASE *) diff --git a/src/core/trace_core.ml b/src/core/trace_core.ml index d89ed8c..2c4a072 100644 --- a/src/core/trace_core.ml +++ b/src/core/trace_core.ml @@ -55,11 +55,11 @@ let[@inline] exit_manual_span espan : unit = | None -> () | Some (module C) -> C.exit_manual_span espan -let[@inline] add_data data : unit = +let[@inline] add_data_to_current_span data : unit = if data <> [] then ( match A.get collector with | None -> () - | Some (module C) -> C.add_data data + | Some (module C) -> C.add_data_to_current_span data ) let[@inline] add_data_to_manual_span esp data : unit = diff --git a/src/core/trace_core.mli b/src/core/trace_core.mli index f5394ff..a1f335e 100644 --- a/src/core/trace_core.mli +++ b/src/core/trace_core.mli @@ -34,7 +34,7 @@ val with_span : see {!enter_manual_span}. *) -val add_data : (string * user_data) list -> unit +val add_data_to_current_span : (string * user_data) list -> unit (** Add structured data to the current, implicit span (see {!with_span}). Behavior is not specified if there is no current span. @since NEXT_RELEASE *) diff --git a/src/tef/trace_tef.ml b/src/tef/trace_tef.ml index acbc77f..2020c9e 100644 --- a/src/tef/trace_tef.ml +++ b/src/tef/trace_tef.ml @@ -410,7 +410,7 @@ let collector ~out () : collector = Fun.protect ~finally (fun () -> f span) - let add_data data = + let add_data_to_current_span data = if data <> [] then ( let tid = get_tid_ () in B_queue.push events (E_add_data { tid; data }) diff --git a/test/t1.ml b/test/t1.ml index 49ff68f..b4db240 100644 --- a/test/t1.ml +++ b/test/t1.ml @@ -17,10 +17,10 @@ let run () = Trace.message "world"; Trace.counter_int "n" !n; - Trace.add_data [ "i", `Int _i ]; + Trace.add_data_to_current_span [ "i", `Int _i ]; if _j = 2 then ( - Trace.add_data [ "j", `Int _j ]; + Trace.add_data_to_current_span [ "j", `Int _j ]; let _sp = Trace.enter_manual_sub_span ~parent:pseudo_async_sp ~flavor: