fix tef-tldrs

This commit is contained in:
Simon Cruanes 2026-01-15 20:42:51 -05:00
parent dc37f68993
commit e2a942fedc
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
3 changed files with 5 additions and 21 deletions

View file

@ -2,10 +2,4 @@
(name trace_tef_tldrs) (name trace_tef_tldrs)
(public_name trace-tef.tldrs) (public_name trace-tef.tldrs)
(synopsis "Multiprocess tracing using the `tldrs` daemon") (synopsis "Multiprocess tracing using the `tldrs` daemon")
(libraries (libraries trace.core trace.util trace-tef unix threads))
trace.core
trace.private.util
trace.subscriber
trace-tef
unix
threads))

View file

@ -84,7 +84,7 @@ let find_role ~out () : role =
| Some path -> Some (write_to_file path) | Some path -> Some (write_to_file path)
| None -> None)) | None -> None))
let subscriber_ (client : as_client) : Trace_subscriber.t = let collector_ (client : as_client) : Collector.t =
(* connect to unix socket *) (* connect to unix socket *)
let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in
(try Unix.connect sock (Unix.ADDR_UNIX client.socket) (try Unix.connect sock (Unix.ADDR_UNIX client.socket)
@ -106,19 +106,13 @@ let subscriber_ (client : as_client) : Trace_subscriber.t =
(fun file -> fpf out "EMIT_TEF_AT_EXIT %s\n" file) (fun file -> fpf out "EMIT_TEF_AT_EXIT %s\n" file)
client.emit_tef_at_exit; client.emit_tef_at_exit;
Trace_tef.Private_.subscriber_jsonl ~finally ~out:(`Output out) () Trace_tef.Private_.collector_jsonl ~finally ~out:(`Output out) ()
let subscriber ~out () =
let role = find_role ~out () in
match role with
| None -> assert false
| Some c -> subscriber_ c
let collector ~out () : collector = let collector ~out () : collector =
let role = find_role ~out () in let role = find_role ~out () in
match role with match role with
| None -> assert false | None -> assert false
| Some c -> subscriber_ c |> Trace_subscriber.collector | Some c -> collector_ c
open struct open struct
let register_atexit = let register_atexit =
@ -136,7 +130,7 @@ let setup ?(out = `Env) () =
| None -> () | None -> ()
| Some c -> | Some c ->
register_atexit (); register_atexit ();
Trace_core.setup_collector @@ Trace_subscriber.collector @@ subscriber_ c Trace_core.setup_collector @@ collector_ c
let with_setup ?out () f = let with_setup ?out () f =
setup ?out (); setup ?out ();

View file

@ -5,10 +5,6 @@ val collector : out:[ `File of string ] -> unit -> Trace_core.collector
(** Make a collector that writes into the given output. See {!setup} for more (** Make a collector that writes into the given output. See {!setup} for more
details. *) details. *)
val subscriber : out:[ `File of string ] -> unit -> Trace_subscriber.t
(** Make a subscriber that writes into the given output.
@since 0.8 *)
type output = [ `File of string ] type output = [ `File of string ]
(** Output for tracing. (** Output for tracing.
- [`File "foo"] will enable tracing and print events into file named "foo". - [`File "foo"] will enable tracing and print events into file named "foo".