From f714482fe480f43393fb654853a5f42f39f91fec Mon Sep 17 00:00:00 2001
From: Simon Cruanes <simon.cruanes.2007@m4x.org>
Date: Thu, 15 Jan 2026 20:53:15 -0500
Subject: [PATCH] address warnings

---
 src/fuchsia/common_.ml    | 1 -
 src/fuchsia/types.ml      | 1 -
 src/tef/collector_tef.ml  | 4 +---
 src/tef/collector_tef.mli | 1 -
 src/tef/types.ml          | 1 -
 src/tef/writer.mli        | 1 -
 6 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/fuchsia/common_.ml b/src/fuchsia/common_.ml
index 3a335a3..b48ced2 100644
--- a/src/fuchsia/common_.ml
+++ b/src/fuchsia/common_.ml
@@ -1,5 +1,4 @@
 module A = Trace_core.Internal_.Atomic_
-module Sub = Trace_subscriber
 
 let on_tracing_error =
   ref (fun s -> Printf.eprintf "trace-fuchsia error: %s\n%!" s)
diff --git a/src/fuchsia/types.ml b/src/fuchsia/types.ml
index e2aaf0d..4fe6be6 100644
--- a/src/fuchsia/types.ml
+++ b/src/fuchsia/types.ml
@@ -1,4 +1,3 @@
-open Trace_core
 module Trace_id = Trace_util.Trace_id64
 
 type trace_id = Trace_id.t
diff --git a/src/tef/collector_tef.ml b/src/tef/collector_tef.ml
index fd390b0..5976167 100644
--- a/src/tef/collector_tef.ml
+++ b/src/tef/collector_tef.ml
@@ -36,7 +36,6 @@ type t = {
   pid: int;
   buf_pool: Buf_pool.t;
   exporter: Exporter.t;
-  span_id_gen: Trace_util.Span_id64.Gen.t;
   trace_id_gen: Trace_util.Trace_id64.Gen.t;
 }
 (** Subscriber state *)
@@ -78,7 +77,6 @@ let create ?(buf_pool = Buf_pool.create ()) ~pid ~exporter () : t =
     exporter;
     buf_pool;
     pid;
-    span_id_gen = Trace_util.Span_id64.Gen.create ();
     trace_id_gen = Trace_util.Trace_id64.Gen.create ();
   }
 
@@ -90,7 +88,6 @@ open struct
     | Core_ext.Extension_span_flavor f :: _ -> f
     | _ :: tl -> flavor_of_params tl
 
-  let new_span_id (self : st) = Trace_util.Span_id64.Gen.gen self.span_id_gen
   let new_trace_id (self : st) = Trace_util.Trace_id64.Gen.gen self.trace_id_gen
   let init _ = ()
   let shutdown (self : st) = close self
@@ -116,6 +113,7 @@ open struct
         | P_some (Span_tef_async sp) -> sp.trace_id
         | _ -> new_trace_id self
       in
+      let data = add_fun_name_ __FUNCTION__ data in
 
       (let@ buf = Trace_util.Rpool.with_ self.buf_pool in
        Writer.emit_begin_async buf ~name ~pid ~tid ~trace_id ~ts:start_us
diff --git a/src/tef/collector_tef.mli b/src/tef/collector_tef.mli
index 1d94a5e..a37224b 100644
--- a/src/tef/collector_tef.mli
+++ b/src/tef/collector_tef.mli
@@ -1,5 +1,4 @@
 open Trace_core
-open Common_
 
 module Buf_pool : sig
   type t
diff --git a/src/tef/types.ml b/src/tef/types.ml
index 535e6d4..5271f5d 100644
--- a/src/tef/types.ml
+++ b/src/tef/types.ml
@@ -1,4 +1,3 @@
-open Trace_core
 module Trace_id = Trace_util.Trace_id64
 
 type trace_id = Trace_id.t
diff --git a/src/tef/writer.mli b/src/tef/writer.mli
index bb53767..34a7461 100644
--- a/src/tef/writer.mli
+++ b/src/tef/writer.mli
@@ -3,7 +3,6 @@
     This is the part of the code that knows how to emit TEF-compliant JSON from
     raw event data. *)
 
-open Common_
 open Types
 
 val emit_duration_event :