simon/tiny_httpd
1
0
Fork 0
mirror of https://github.com/c-cube/tiny_httpd.git synced 2025-12-08 12:15:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf: only call select in accept loop if accept would have blocked

Browse source
This commit is contained in:
Simon Cruanes 2024-02-17 11:51:50 -05:00
parent 217defecc5
commit 20a36919ce
No known key found for this signature in database
GPG key ID: EBFFF6F283F3A2B4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Tiny_httpd_server.ml
View file

@ -984,7 +984,6 @@ module Unix_tcp_server_ = struct
Unix.set_nonblock sock; Unix.set_nonblock sock;
while self.running do while self.running do
ignore (Unix.select [ sock ] [] [ sock ] 1.0 : _ * _ * _);
match Unix.accept sock with match Unix.accept sock with
| client_sock, client_addr -> | client_sock, client_addr ->
(* limit concurrency *) (* limit concurrency *)
@ -1012,7 +1011,8 @@ module Unix_tcp_server_ = struct
ignore Unix.(sigprocmask SIG_UNBLOCK Sys.[ sigint; sighup ]) ignore Unix.(sigprocmask SIG_UNBLOCK Sys.[ sigint; sighup ])
| exception Unix.Unix_error ((Unix.EAGAIN | Unix.EWOULDBLOCK), _, _) | exception Unix.Unix_error ((Unix.EAGAIN | Unix.EWOULDBLOCK), _, _)
-> ->
() (* wait for the socket to be ready, and re-enter the loop *)
ignore (Unix.select [ sock ] [] [ sock ] 1.0 : _ * _ * _)
| exception e -> | exception e ->
Log.error (fun k -> Log.error (fun k ->
k "Unix.accept or Thread.create raised an exception: %s" k "Unix.accept or Thread.create raised an exception: %s"