simon/tiny_httpd
1
0
Fork 0
mirror of https://github.com/c-cube/tiny_httpd.git synced 2025-12-06 11:15:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: make check for 'Connection: Upgrade' header case-insensitive

Browse source 
Some clients send lowercase 'upgrade' as value (matching typical keep-alive behaviour)
This commit is contained in:
Sam Tombury 2024-11-07 13:08:01 +00:00 • committed by Simon Cruanes
parent d38eb852f8
commit b80c5f922f
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/server.ml
View file

@ -311,9 +311,11 @@ let find_map f l =
in in
aux f l aux f l
let string_as_list_contains_ (s : string) (sub : string) : bool = let header_list_contains_ (s : string) (name : string) : bool =
let name' = String.lowercase_ascii name in
let fragments = String.split_on_char ',' s in let fragments = String.split_on_char ',' s in
List.exists (fun fragment -> String.trim fragment = sub) fragments List.exists (fun fragment ->
String.lowercase_ascii (String.trim fragment) = name') fragments
(* handle client on [ic] and [oc] *) (* handle client on [ic] and [oc] *)
let client_handle_for (self : t) ~client_addr ic oc : unit = let client_handle_for (self : t) ~client_addr ic oc : unit =
@ -379,7 +381,7 @@ let client_handle_for (self : t) ~client_addr ic oc : unit =
(* check headers *) (* check headers *)
(match Request.get_header req "connection" with (match Request.get_header req "connection" with
| Some str when string_as_list_contains_ str "Upgrade" -> () | Some str when header_list_contains_ str "Upgrade" -> ()
| _ -> bad_reqf 426 "connection header must contain 'Upgrade'"); | _ -> bad_reqf 426 "connection header must contain 'Upgrade'");
(match Request.get_header req "upgrade" with (match Request.get_header req "upgrade" with
| Some u when u = UP.name -> () | Some u when u = UP.name -> ()