perf(drup): restore Atoms as integers

src/checker/drup_check.ml

@@ -1,54 +1,5 @@
 
-module SDrup = Sidekick_drup
+include Sidekick_drup.Make()
-
-module Atom : sig
-  include SDrup.ATOM with type t = private int
-
-  val of_int : int -> t
-end = struct
-  type t = int
-  type atom = t
-  let hash = CCHash.int
-  let equal : t -> t -> bool = (=)
-  let compare : t -> t -> int = compare
-  let[@inline] neg x = x lxor 1
-  let[@inline] of_int x =
-    let v = abs x lsl 1 in
-    if x < 0 then neg v else v
-  let[@inline] sign x = (x land 1) = 0
-  let[@inline] to_int x = (if sign x then 1 else -1) * (x lsr 1)
-  let pp out x =
-    Fmt.fprintf out "%s%d" (if sign x then "+" else "-") (x lsr 1)
-  let[@inline] of_int_unsafe i = i
-  let dummy = 0
-  module Assign = struct
-    type t = Bitvec.t
-    let create = Bitvec.create
-    let ensure_size = Bitvec.ensure_size
-    let is_true = Bitvec.get
-    let[@inline] is_false self (a:atom) : bool =
-      is_true self (neg a)
-    let[@inline] is_unassigned self a =
-      not (is_true self a) && not (is_false self a)
-    let set = Bitvec.set
-  end
-  module Map = struct
-    type 'a t = 'a Vec.t
-    let create () = Vec.create ()
-    let[@inline] ensure_has (self:_ t) a mk : unit =
-      (* size: 2+atom, because: 1+atom makes atom valid, and if it's positive,
-         2+atom is (¬atom)+1 *)
-      Vec.ensure_size_with self mk (2+(a:atom:>int))
-    let get = Vec.get
-    let set = Vec.set
-  end
-  module Stack = struct
-    include VecI32
-    let create()=create()
-  end
-end
-
-include SDrup.Make(Atom)
 
 (** A DRUP trace, as a series of operations *)
 module Trace : sig

src/checker/main.ml

@@ -3,7 +3,7 @@ module BL = Sidekick_bin_lib
 
 let clause_of_int_l store atoms : Drup_check.clause =
   atoms
-  |> CCList.map Drup_check.Atom.of_int
+  |> CCList.map Drup_check.Atom.of_int_dimacs
   |> Drup_check.Clause.of_list store
 
 let check ?pb proof : bool =

src/drup/sidekick_drup.ml

@@ -8,9 +8,14 @@
 module Fmt = CCFormat
 module VecI32 = VecI32
 
-(** Signature for boolean atoms *)
+(* TODO: resolution proof construction, optionally *)
-module type ATOM = sig
+
-  type t
+(* TODO: backward checking + pruning of traces *)
+
+(** An instance of the checker *)
+module type S = sig
+  module Atom : sig
+    type t = private int
     val equal : t -> t -> bool
     val compare : t -> t -> int
     val hash : t -> int
@@ -18,47 +23,15 @@ module type ATOM = sig
     val sign : t -> bool
     val pp : t Fmt.printer
 
-  val dummy : t
-
     type atom = t
 
-  module Assign : sig
+    val of_int_dimacs : int -> t
-    type t
+    (** Turn a signed integer into an atom. Positive integers are
-    val create : unit -> t
+        positive atoms, and [-i] is [neg (of_int i)].
-
+        @raise Invalid_argument if the argument is 0 *)
-    val ensure_size : t -> atom -> unit
-    val set : t -> atom -> bool -> unit
-    val is_true : t -> atom -> bool
-    val is_false : t -> atom -> bool
-    val is_unassigned : t -> atom -> bool
   end
+  type atom = Atom.t
 
-  module Map : sig
-    type 'a t
-    val create : unit -> 'a t
-    val ensure_has : 'a t -> atom -> (unit -> 'a) -> unit
-    val get : 'a t -> atom -> 'a
-  end
-
-  module Stack : sig
-    type t
-    val create : unit -> t
-    val get : t -> int -> atom
-    val set : t -> int -> atom -> unit
-    val push : t -> atom -> unit
-    val size : t -> int
-    val shrink : t -> int -> unit
-    val to_iter : t -> atom Iter.t
-  end
-end
-
-(* TODO: resolution proof construction, optionally *)
-
-(* TODO: backward checking + pruning of traces *)
-
-(** An instance of the checker *)
-module type S = sig
-  type atom
 
   module Clause : sig
 
@@ -92,10 +65,51 @@ module type S = sig
   end
 end
 
-module[@inline] Make(A : ATOM)
+module Make() : S = struct
-  : S with type atom = A.t
+  (** Boolean atoms *)
-= struct
+  module Atom = struct
-  module Atom = A
+    type t = int
+    type atom = t
+    let hash = CCHash.int
+    let equal : t -> t -> bool = (=)
+    let compare : t -> t -> int = compare
+    let[@inline] neg x = x lxor 1
+    let[@inline] of_int_dimacs x =
+      if x=0 then invalid_arg "Atom.of_int_dimacs: 0 is not acceptable";
+      let v = abs x lsl 1 in
+      if x < 0 then neg v else v
+    let[@inline] sign x = (x land 1) = 0
+    let[@inline] to_int x = (if sign x then 1 else -1) * (x lsr 1)
+    let pp out x =
+      Fmt.fprintf out "%s%d" (if sign x then "+" else "-") (x lsr 1)
+    let[@inline] of_int_unsafe i = i
+    let dummy = 0
+    module Assign = struct
+      type t = Bitvec.t
+      let create = Bitvec.create
+      let ensure_size = Bitvec.ensure_size
+      let is_true = Bitvec.get
+      let[@inline] is_false self (a:atom) : bool =
+        is_true self (neg a)
+      let[@inline] is_unassigned self a =
+        not (is_true self a) && not (is_false self a)
+      let set = Bitvec.set
+    end
+    module Map = struct
+      type 'a t = 'a Vec.t
+      let create () = Vec.create ()
+      let[@inline] ensure_has (self:_ t) a mk : unit =
+        (* size: 2+atom, because: 1+atom makes atom valid, and if it's positive,
+           2+atom is (¬atom)+1 *)
+        Vec.ensure_size_with self mk (2+(a:atom:>int))
+      let get = Vec.get
+      let set = Vec.set
+    end
+    module Stack = struct
+      include VecI32
+      let create()=create()
+    end
+  end
   type atom = Atom.t
 
   (** Boolean clauses *)